Pubmatic: add dctr and pmzoneid params #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Jun 15, 2021
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
SerhiiNahornyi
suggested changes
Jun 17, 2021
| eachKv.add(String.format("\"%s\":\"%s\"", keyVal.getKey(), | ||
| String.join(",", keyVal.getValue()))); | ||
| private ObjectNode makeKeywords(ExtImpPubmatic extImpPubmatic) { | ||
| final ObjectNode keywordsObjectNode = mapper.mapper().createObjectNode(); |
There was a problem hiding this comment.
keywordsNode enough
Comment on lines
644
to
648
| assertThat(result.getValue()).hasSize(1) | ||
| .extracting(HttpRequest::getPayload) | ||
| .flatExtracting(BidRequest::getImp) | ||
| .extracting(Imp::getExt) | ||
| .containsOnly(mapper.readValue("{\"key_val\":\"dctr\"}", ObjectNode.class)); |
There was a problem hiding this comment.
Let's first create expected map and than convert it, also instead of containsOnly use ContainsExactly.
So result will look like
final Map<String, String> expectedKeyWords = singletonMap("key_val", "dctr");
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1)
.extracting(HttpRequest::getPayload)
.flatExtracting(BidRequest::getImp)
.extracting(Imp::getExt)
.containsExactly(mapper.convertValue(expectedKeyWords, ObjectNode.class));Pls prepare this changes for every test
SerhiiNahornyi
approved these changes
Jun 17, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.