Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PriceGranularity logic to work with missing values #1324

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Update PriceGranularity logic to work with missing values #1324

merged 3 commits into from
Jun 23, 2021

Conversation

SerhiiNahornyi
Copy link
Collaborator

Fixes

2021-06-10T18:20:18.605+03:00	2021-06-10 15:20:18.604 ERROR 11 --- [ntloop-thread-3] o.p.s.handler.openrtb2.AuctionHandler : Critical error while running the auction

2021-06-10T18:20:18.605+03:00	java.lang.NullPointerException: null
2021-06-10T18:20:18.605+03:00	at java.util.Objects.requireNonNull(Objects.java:203)
2021-06-10T18:20:18.605+03:00	at java.util.Optional.<init>(Optional.java:96)
2021-06-10T18:20:18.605+03:00	at java.util.Optional.of(Optional.java:108)
2021-06-10T18:20:18.605+03:00	at java.util.stream.ReduceOps$2ReducingSink.get(ReduceOps.java:129)
2021-06-10T18:20:18.605+03:00	at java.util.stream.ReduceOps$2ReducingSink.get(ReduceOps.java:107)
2021-06-10T18:20:18.605+03:00	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
2021-06-10T18:20:18.605+03:00	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2021-06-10T18:20:18.605+03:00	at java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:479)
2021-06-10T18:20:18.605+03:00	at java.util.stream.ReferencePipeline.max(ReferencePipeline.java:515)
2021-06-10T18:20:18.605+03:00	at org.prebid.server.auction.PriceGranularity.createFromRanges(PriceGranularity.java:114)
2021-06-10T18:20:18.605+03:00	at

@rpanchyk rpanchyk merged commit 7cf4c57 into master Jun 23, 2021
@rpanchyk rpanchyk deleted the fix/priceGranularity/npe branch June 23, 2021 10:01
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
@SerhiiNahornyi
Update PriceGranularity logic to work with missing values (#1324)
535fb86
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
Update PriceGranularity logic to work with missing values (#1324)
a66a8c4
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
Update PriceGranularity logic to work with missing values (#1324)
724952d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanchyk rpanchyk rpanchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SerhiiNahornyi @rpanchyk