Add auctionId to PBS events strings #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 18, 2021 11:04
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/vast/VastModifier.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/vast/VastModifierTest.java # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-cache-matcher-rubicon-appnexus.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-cache-rubicon-appnexus-request.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus_multi_bid/test-auction-rubicon-appnexus-response.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus_multi_bid/test-cache-matcher-rubicon-appnexus.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus_multi_bid/test-cache-rubicon-appnexus-request.json
# Conflicts: # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
rpanchyk
suggested changes
Jul 7, 2021
| @@ -170,6 +170,7 @@ private static int validateTruncateAttrChars(int truncateAttrChars) { | |||
| final long auctionTimestamp = auctionTimestamp(auctionContext); | |||
| final Account account = auctionContext.getAccount(); | |||
| final List<String> debugWarnings = auctionContext.getDebugWarnings(); | |||
| final String auctionId = bidRequest.getId(); | |||
There was a problem hiding this comment.
i'd say it should be named as requestId or bidRequestId since auctionId is event-specific term and core should not care how it used in events.
SerhiiNahornyi
force-pushed
the
events/add/aid_param
branch
from
5f55b77 to
3646679
Compare
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
SerhiiNahornyi
force-pushed
the
events/add/aid_param
branch
from
3646679 to
248f63f
Compare
rpanchyk
approved these changes
Jul 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.