BeachfrontBidder: fix beachfront bid floor #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Jun 30, 2021
Comment on lines
249
to
250
| extImpBeachfrontBidfloor = extImpBeachfrontBidfloor == null ? ZERO : extImpBeachfrontBidfloor; | ||
| impBidfloor = impBidfloor == null ? ZERO : impBidfloor; |
There was a problem hiding this comment.
Let's create separate variables, and not use method arguments assignments
Comment on lines
248
to
261
| private static BigDecimal getBidFloor(BigDecimal extImpBeachfrontBidfloor, BigDecimal impBidfloor) { | ||
| extImpBeachfrontBidfloor = extImpBeachfrontBidfloor == null ? ZERO : extImpBeachfrontBidfloor; | ||
| impBidfloor = impBidfloor == null ? ZERO : impBidfloor; | ||
| final BigDecimal resultFloor; | ||
|
|
||
| if (impBidfloor.compareTo(ZERO) > 0) { | ||
| resultFloor = impBidfloor; | ||
| } else if (extImpBeachfrontBidfloor.compareTo(ZERO) > 0) { | ||
| resultFloor = extImpBeachfrontBidfloor; | ||
| } else { | ||
| resultFloor = MIN_BID_FLOOR; | ||
| } | ||
|
|
||
| return resultFloor.compareTo(MIN_BID_FLOOR) < 0 ? MIN_BID_FLOOR : resultFloor; |
There was a problem hiding this comment.
Can we refactor to something like this
private static BigDecimal getBidFloor(BigDecimal extImpBidfloor, BigDecimal impBidfloor) {
final BigDecimal impNonNullBidfloor = zeroIfNull(impBidfloor);
final BigDecimal extImpNonNullBidfloor = zeroIfNull(extImpBidfloor);
if (impNonNullBidfloor.compareTo(MIN_BID_FLOOR) > 0) {
return impNonNullBidfloor;
} else if (extImpNonNullBidfloor.compareTo(MIN_BID_FLOOR) > 0) {
return extImpNonNullBidfloor;
} else {
return ZERO;
}
}
public static BigDecimal zeroIfNull(BigDecimal bigDecimal) {
return bigDecimal == null ? BigDecimal.ZERO : bigDecimal;
}| final BigDecimal resultFloor; | ||
|
|
||
| if (impBidfloor.compareTo(ZERO) > 0) { | ||
| resultFloor = impBidfloor; |
There was a problem hiding this comment.
Let's add test for this case
| @@ -64,6 +64,7 @@ | |||
| private static final BigDecimal MIN_BID_FLOOR = BigDecimal.valueOf(0.01); | |||
| private static final int DEFAULT_VIDEO_WIDTH = 300; | |||
| private static final int DEFAULT_VIDEO_HEIGHT = 250; | |||
| private static final BigDecimal ZERO = BigDecimal.ZERO; | |||
There was a problem hiding this comment.
Do we really need it?
SerhiiNahornyi
approved these changes
Jul 1, 2021
nickluck9
pushed a commit
that referenced
this pull request
Jul 8, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.