Add bidscube bidder

[And1sS]

No description provided.

[SerhiiNahornyi]

Bidscube

[SerhiiNahornyi]

In go they take "bidder" property and then set it as ext

bidderExt, bidderExtExists := impExt["bidder"]
...
impression.Ext = bidderExt

[SerhiiNahornyi]

We don't need converting, just Node replacement instead of full ext, just it bidder property

[SerhiiNahornyi]

Let's add this test case givenBid("123", null))

[SerhiiNahornyi]

Let's update this code to this one

private static BidderBid constructBidderBid(Bid bid, BidResponse bidResponse, List<BidderError> errors) {
        final JsonNode bidExt = bid.getExt();
        final JsonNode prebidNode = isNotEmptyOrMissedNode(bidExt) ? bidExt.get("prebid") : null;
        final JsonNode typeNode = isNotEmptyOrMissedNode(prebidNode) ? prebidNode.get("type") : null;
        if (typeNode == null || !typeNode.isTextual()) {
            errors.add(BidderError.badInput("Unable to read bid.ext.prebid.type"));
            return null;
        }

        return BidderBid.of(bid, resolveBidType(typeNode.asText()), bidResponse.getCur());
    }

    private static boolean isNotEmptyOrMissedNode(JsonNode node) {
        return node != null && !node.isEmpty();
    }

    private static BidType resolveBidType(String bidType) {
        if (!POSSIBLE_BID_TYPES.contains(bidType)) {
            return BidType.banner;
        }
        return BidType.valueOf(bidType);
    }

And POSSIBLE_BID_TYPES to ImmutableSet.of("banner", "video", "native")
Now we can work only with String as in go and with unknown media types

[SerhiiNahornyi]

Should we also check if value is missed?

[SerhiiNahornyi]

assertThat(result.getValue()).isEmpty();

[SerhiiNahornyi]

assertThat(result.getValue()).isEmpty();