Fill initial bid request with all possible values from query parameters and headers during AMP processing #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 5, 2021 15:05
…rs and headers during AMP processing
…nd simplify AmpRequestFactory
rpanchyk
approved these changes
Jul 5, 2021
| */ | ||
| private static Integer debugFromQueryStringParam(HttpRequestContext httpRequest) { | ||
| final String debug = httpRequest.getQueryParams().get(DEBUG_REQUEST_PARAM); | ||
| return Objects.equals(debug, "1") ? Integer.valueOf(1) : Objects.equals(debug, "0") ? 0 : null; |
There was a problem hiding this comment.
Minor. We can use next construction here:
return StringUtils.equalsAny(debug, "0", "1") ? Integer.valueOf(debug) : null;
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
…rs and headers during AMP processing (#1353) * Fill initial bid request with all possible values from query parameters and headers during AMP processing * Drop request.ext validation in AMP (since it is always present now) and simplify AmpRequestFactory * Cleanup after refactoring
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
…rs and headers during AMP processing (#1353) * Fill initial bid request with all possible values from query parameters and headers during AMP processing * Drop request.ext validation in AMP (since it is always present now) and simplify AmpRequestFactory * Cleanup after refactoring
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
…rs and headers during AMP processing (#1353) * Fill initial bid request with all possible values from query parameters and headers during AMP processing * Drop request.ext validation in AMP (since it is always present now) and simplify AmpRequestFactory * Cleanup after refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.