Review PubmaticBidder #1371
Merged
Review PubmaticBidder #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2021 21:46
SerhiiNahornyi
commented
Jul 13, 2021
|
|
||
| updateImpWithAdSlotParameters(impBuilder, impExt.getBidder().getAdSlot(), banner); | ||
| if (banner != null) { | ||
| impBuilder.banner(assignSizesIfMissing(impBuilder.build().getBanner())); |
There was a problem hiding this comment.
Pls take a look on this line, can this be used or updates should be prepared
There was a problem hiding this comment.
Yeah, it looks kind of cryptic.
Can we do assignSizesIfMissing actions in updateImpWithAdSlotParameters ?
rpanchyk
suggested changes
Jul 19, 2021
|
|
||
| updateImpWithAdSlotParameters(impBuilder, impExt.getBidder().getAdSlot(), banner); | ||
| if (banner != null) { | ||
| impBuilder.banner(assignSizesIfMissing(impBuilder.build().getBanner())); |
There was a problem hiding this comment.
Yeah, it looks kind of cryptic.
Can we do assignSizesIfMissing actions in updateImpWithAdSlotParameters ?
| } | ||
| final Banner updatedBanner = banner.toBuilder().w(width).h(height).build(); | ||
| modifiedImp.banner(updatedBanner); | ||
| private void updateImpWithAdSlotParameters(Imp.ImpBuilder impBuilder, String adSlot, Banner banner) { |
There was a problem hiding this comment.
Ideally, this method should returm Imp object.
rpanchyk
approved these changes
Jul 19, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.