Review Ix bidder #1372
Merged
Review Ix bidder #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 15, 2021 20:48
rpanchyk
suggested changes
Jul 19, 2021
| .h(banner.getH()) | ||
| .build(); | ||
| if (bidType == BidType.video) { | ||
| updateWithVideoAttributes(bidBuilder, bid.getExt(), bid.getCat()); |
There was a problem hiding this comment.
Pls avoid passing of builder as an arguments.
Especially in this case, we won't affect the performance since the condition.
btw, we can use ternary operator for return statement.
|
|
||
| private void updateWithNativeAttributes(Bid.BidBuilder bidBuilder, String adm) { | ||
| final NativeV11Wrapper nativeV11 = parseBidAdm(adm, NativeV11Wrapper.class); | ||
| final Response v11Response = getIfNotNull(nativeV11, NativeV11Wrapper::getNativeResponse); |
There was a problem hiding this comment.
Pls rename v11Response to responseV11.
| return target != null ? getter.apply(target) : null; | ||
| } | ||
|
|
||
| private String updateAdm(Response response, boolean isV11) { |
There was a problem hiding this comment.
i'd suggest to inline this method.
And1sS
reviewed
Jul 19, 2021
| .build(); | ||
| if (bidType == BidType.video) { | ||
| updateWithVideoAttributes(bidBuilder, bid.getExt(), bid.getCat()); | ||
| } else { |
There was a problem hiding this comment.
else if (bidType == BidType.xNative)
There was a problem hiding this comment.
Seems it is already checked above.
added 2 commits
July 19, 2021 22:02
# Conflicts: # src/test/resources/org/prebid/server/it/openrtb2/ix/test-auction-ix-response.json
rpanchyk
approved these changes
Jul 21, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.