Added medianet adapter #1378
Added medianet adapter #1378
Conversation
src/test/java/org/prebid/server/bidder/medianet/MedianetBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/medianet/MedianetBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/medianet/MedianetBidderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/MedianetConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/medianet/MedianetBidder.java
Outdated
Show resolved
Hide resolved
src/test/resources/org/prebid/server/it/openrtb2/medianet/test-auction-medianet-request.json
Outdated
Show resolved
Hide resolved
|
Hey, @And1sS @snahornyi . |
… medianet-adapter-integration
| public class MedianetBidderTest extends VertxTest { | ||
|
|
||
| private static final String ENDPOINT_URL = "https://test.media.net?src=external.prebidserver.com"; | ||
| private static final BidRequest DUMMY_REQUEST = BidRequest.builder() |
There was a problem hiding this comment.
We prefer to use givenBidRequest method, you can check examples in another test classes
There was a problem hiding this comment.
Changed to 'given' nomenclature
| String encodedExternalUrl = HttpUtil.encodeUrl(externalUrl); | ||
| String bidderEndpoint = configEndpoint.replace(EXTERNAL_URL_MACRO, encodedExternalUrl); |
There was a problem hiding this comment.
56 line can be merged to 57 and also we prefer to declare variables as final
There was a problem hiding this comment.
And even more better, pls create create method resolveEndpoint and then pass it to constructor, which will be in medianetBidderDeps method
There was a problem hiding this comment.
private String resolveEndpoint(String configEndpoint) {
return configEndpoint.replace(EXTERNAL_URL_MACRO, HttpUtil.encodeUrl(externalUrl));
}There was a problem hiding this comment.
Added this method, and calling it in medianetBidderDeps()
Adds Media.Net Bidder Adapter.
Vendor ID: 142
Maintainer Email: prebid@media.net