Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ix bidder: make impTrackers to always be unique #1396

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

SerhiiNahornyi
Copy link
Collaborator

No description provided.

@rpanchyk rpanchyk merged commit f962f5f into master Jul 29, 2021
@rpanchyk rpanchyk deleted the ix/unique/imp_ids branch July 29, 2021 14:07
DGarbar added a commit that referenced this pull request Sep 6, 2021
* TimeoutBidder interface added.
FacebookBidder migrate from Bidder to TimeoutBidder

* TimeoutBidder interface added.
FacebookBidder migrate from Bidder to TimeoutBidder

* Added extra validation

* cs fix

* Facebook Bidder logic fix

* test added

* cs

* Refactor timeout handling

* Simplify timeout notification creation by Facebook

* Extract timeout and facebook notification URL to configuration

* Fix javadoc

* Revert unintended change

* Send timeout notification metrics

* Move timeout notification logic into separate component - BidderErrorNotifier

* Add logging of timeout notifications

* Remove site support

* Make changes regarding `Facebook Only Supports App Impressions #1396`

* Remove bidder common issues (#1009)

* Remove bidder common issues

* Make x-openrtb-version header in HttpUtil

* Fixes after review

* Add single value method

* Change error method name

* Fixes after merge

Co-authored-by: rpanchyk <rpanchyk@rubiconproject.com>
Co-authored-by: Sergii Chernysh <schernysh@rubiconproject.com>
Co-authored-by: apavlyuk <apavlyuk@rubiconproject.com>
Co-authored-by: DGarbar <dimagarbar49@gmail.com>
Co-authored-by: Serhii Nahornyi <sergiy3344@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants