Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerizonMedia rebranding into YSSP #1409

Closed
wants to merge 1 commit into from

Conversation

oath-jac
Copy link
Contributor

@oath-jac oath-jac commented Aug 6, 2021

We have to drop the verizonmedia brand, for this the following steps will be done:

  • clone VerizonMedia adapter into the YSSP adapter
  • move any publishers to the new yssp adapter
  • when everybody was migrated, we'll delete the VerizonMedia adapter

@rpanchyk
Copy link
Contributor

rpanchyk commented Aug 6, 2021

Hi @oath-jac PBS has possibility to configure bidder alias adapters.<BIDDER_NAME>.aliases.<BIDDER_ALIAS> with all any custom config params. So, you can rename (rebrand) existing VerizonMediainto YSSP in code, but add alias for the VerizonMedia one (with all existing URLs, etc.) in YSSP config.
Thus, all three steps can be done at once. Please consider this way.

@slimkrazy
Copy link

@rpanchyk - Thanks for this alternate approach. We're going to discuss going this way. For now if this PR could be left on hold that would be great.

@rpanchyk rpanchyk added the work in progress Signals not finished work label Aug 9, 2021
@oath-jac
Copy link
Contributor Author

Hi,

I opened a new PR where we followed your suggestion, we renamed the current VerizonMedia adapter with adding the verizonmedia alias.

The new PR is here #1439
We could close this.

@rpanchyk rpanchyk closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Signals not finished work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants