Turn off debugging by Publisher, by Bidder #1423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/prebid/server/proto/response/BidderInfo.java # src/main/java/org/prebid/server/spring/config/bidder/util/BidderInfoCreator.java # src/test/java/org/prebid/server/handler/CookieSyncHandlerTest.java # src/test/java/org/prebid/server/handler/info/BidderDetailsHandlerTest.java # src/test/java/org/prebid/server/validation/BidderParamValidatorTest.java
# Conflicts: # src/main/java/org/prebid/server/settings/model/Account.java # src/test/resources/org/prebid/server/it/test-app-settings.yaml
rpanchyk
suggested changes
Aug 25, 2021
| @@ -400,6 +400,7 @@ Let's assume following table schema for example: | |||
| `price_granularity` enum('low','med','high','auto','dense','unknown') NOT NULL DEFAULT 'unknown', | |||
| `banner_cache_ttl` int(11) DEFAULT NULL, | |||
| `video_cache_ttl` int(11) DEFAULT NULL, | |||
| `debug_allowed` bit(1) DEFAULT NULL, | |||
There was a problem hiding this comment.
This column should be omitted and can be stored asconfig.auction.debug-allowed in config JSON column.
| final BidRequest bidRequest = auctionContext.getBidRequest(); | ||
| final ExtRequestPrebid extRequestPrebid = getIfNotNull(bidRequest.getExt(), ExtRequest::getPrebid); | ||
|
|
||
| final boolean publisherAllowed = isPublisherAllowed(auctionContext); |
There was a problem hiding this comment.
Please use account terminology instead of publisher to be in one style with other code.
| this.debugOverrideToken = debugOverrideToken; | ||
| } | ||
|
|
||
| public DebugContext getDebugContext(AuctionContext auctionContext) { |
There was a problem hiding this comment.
Minor. Consider to rename the method to debugContextFrom(..).
| @@ -12,7 +12,12 @@ accounts: | |||
| auction: | |||
| events: | |||
| enabled: true | |||
| eventsEnabled: true | |||
There was a problem hiding this comment.
Pls don't forget to remove after master is merged.
|
See #1443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.