Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code style documentation #1469

Merged
merged 7 commits into from
Sep 14, 2021
Merged

Add code style documentation #1469

merged 7 commits into from
Sep 14, 2021

Conversation

rpanchyk
Copy link
Contributor

No description provided.

docs/code-style.md Outdated Show resolved Hide resolved
SerhiiNahornyi
SerhiiNahornyi previously approved these changes Sep 13, 2021
@And1sS
Copy link
Member

And1sS commented Sep 13, 2021

What do you think about adding this section?

### Data retrieval calls of same result
Try not to retrieve same data more than once:

// bad
if (getData() != null) {
   final Data resolvedData = resolveData(getData());

//  good
final Data data = getData();
if (data != null) {
   final Data resolvedData = resolveData(data);

And1sS
And1sS previously approved these changes Sep 13, 2021
Net-burst
Net-burst previously approved these changes Sep 13, 2021
docs/code-style.md Outdated Show resolved Hide resolved
docs/code-style.md Outdated Show resolved Hide resolved
docs/code-style.md Outdated Show resolved Hide resolved
docs/code-style.md Outdated Show resolved Hide resolved
docs/code-style.md Show resolved Hide resolved
docs/code-style.md Show resolved Hide resolved
docs/code-style.md Show resolved Hide resolved
docs/code-style.md Outdated Show resolved Hide resolved
docs/code-style.md Show resolved Hide resolved
@rpanchyk rpanchyk dismissed stale reviews from Net-burst, And1sS, and SerhiiNahornyi via 8b44e52 September 14, 2021 06:11
@rpanchyk rpanchyk merged commit c916cef into master Sep 14, 2021
@rpanchyk rpanchyk deleted the add-code-style-doc branch September 14, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants