Rename integration to channel in account config tests #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtuchkova
requested review from
Net-burst,
And1sS,
rpanchyk,
SerhiiNahornyi and
yevhenii-viktorov
mtuchkova
force-pushed
the
rename-integration-channel-config-tests
branch
2 times, most recently
from
459e658 to
00db932
Compare
Net-burst
requested changes
Dec 17, 2021
|
|
||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| @JsonNaming(PropertyNamingStrategies.KebabCaseStrategy) | ||
| class AccountCcpaConfig { | ||
|
|
||
| Boolean enabled | ||
| @JsonProperty("channel-enabled") | ||
| Map<ChannelType, Boolean> enabledForRequestType |
There was a problem hiding this comment.
Please rename the underlying field too.
|
|
||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| @JsonNaming(PropertyNamingStrategies.KebabCaseStrategy) | ||
| class AccountGdprConfig { | ||
|
|
||
| Boolean enabled | ||
| @JsonProperty("channel-enabled") | ||
| Map<ChannelType, Boolean> enabledForRequestType |
There was a problem hiding this comment.
Please rename the underlying property too.
src/test/groovy/org/prebid/server/functional/model/request/amp/AmpRequest.groovy
Show resolved
Hide resolved
| @@ -29,14 +33,19 @@ class BidRequest { | |||
| Regs regs | |||
| BidRequestExt ext | |||
|
|
|||
| static BidRequest getDefaultBidRequest() { | |||
| static BidRequest getDefaultBidRequest(ChannelType channelType = WEB) { | |||
| import org.testcontainers.containers.GenericContainer | ||
| import org.testcontainers.containers.MySQLContainer | ||
| import org.testcontainers.containers.wait.strategy.Wait | ||
|
|
||
| import static org.prebid.server.functional.util.privacy.TcfConsent.RUBICON_VENDOR_ID |
There was a problem hiding this comment.
Bad place for this. This is only needed for Privacy tests. No point having it for everything.
| "adapters.generic.endpoint" : "$host/auction" as String, | ||
| "adapters.generic.usersync.url" : "$host/generic-usersync" as String, | ||
| "adapters.generic.usersync.type": "redirect", | ||
| "adapters.generic.meta-info.vendor-id": RUBICON_VENDOR_ID as String |
There was a problem hiding this comment.
Same. Looks like this shouldn't be here.
mtuchkova
force-pushed
the
rename-integration-channel-config-tests
branch
from
00db932 to
206cf6e
Compare
hupaloo
previously approved these changes
Dec 31, 2021
src/test/groovy/org/prebid/server/functional/tests/privacy/CcpaAmpSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/CcpaAuctionSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/CcpaAuctionSpec.groovy
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GdprAuctionSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GdprAuctionSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/PrivacyBaseSpec.groovy
Outdated
Show resolved
Hide resolved
mtuchkova
force-pushed
the
rename-integration-channel-config-tests
branch
from
206cf6e to
e28faba
Compare
hupaloo
previously approved these changes
Feb 16, 2022
mtuchkova
force-pushed
the
rename-integration-channel-config-tests
branch
from
143261f to
37c162f
Compare
mtuchkova
force-pushed
the
rename-integration-channel-config-tests
branch
from
37c162f to
4c83e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #1558