-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds implementation for DebugWarnings #1626
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevhenii-viktorov
requested review from
Net-burst,
And1sS,
rpanchyk,
mtuchkova and
SerhiiNahornyi
December 13, 2021 10:27
SerhiiNahornyi
force-pushed
the
refactoring/debug-warnings
branch
from
December 17, 2021 18:06
1079792
to
b197e53
Compare
… refactoring/debug-warnings # Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/auction/OrtbTypesResolver.java # src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java # src/main/java/org/prebid/server/auction/model/AuctionContext.java # src/main/java/org/prebid/server/auction/model/BidderMessageType.java # src/main/java/org/prebid/server/auction/model/PrebidLog.java # src/main/java/org/prebid/server/auction/model/PrivacyMessageType.java # src/main/java/org/prebid/server/privacy/PrivacyExtractor.java # src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java # src/main/java/org/prebid/server/vast/VastModifier.java # src/test/java/org/prebid/server/privacy/PrivacyExtractorTest.java
… refactoring/debug-warnings # Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java
…arnings # Conflicts: # src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java # src/test/java/org/prebid/server/auction/requestfactory/AmpRequestFactoryTest.java
And1sS
requested changes
Jan 10, 2022
src/main/java/org/prebid/server/auction/model/BidderMessageFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/model/BidderMessageFactory.java
Outdated
Show resolved
Hide resolved
And1sS
requested changes
Jan 10, 2022
And1sS
requested changes
Jan 19, 2022
src/main/java/org/prebid/server/auction/model/GenericMessageFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BasicCategoryMappingServiceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/model/CategoryMappingMessageType.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/OrtbTypesResolverTest.java
Outdated
Show resolved
Hide resolved
rpanchyk
reviewed
Jan 21, 2022
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java
Outdated
Show resolved
Hide resolved
… refactoring/debug-warnings
And1sS
requested changes
Jan 21, 2022
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/requestfactory/Ortb2RequestFactory.java
Outdated
Show resolved
Hide resolved
rpanchyk
previously approved these changes
Jan 24, 2022
…arnings # Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java # src/main/java/org/prebid/server/auction/requestfactory/AmpRequestFactory.java # src/main/java/org/prebid/server/privacy/PrivacyExtractor.java # src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java # src/test/java/org/prebid/server/auction/requestfactory/AmpRequestFactoryTest.java # src/test/java/org/prebid/server/privacy/gdpr/TcfDefinerServiceTest.java
…arnings # Conflicts: # src/test/java/org/prebid/server/floors/BasicPriceFloorProcessorTest.java
… refactoring/debug-warnings
Will be reimplemented in future releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General idea: prebid/prebid-server#1650
Implemented here:
Minor implementation was done here: #1169