Extend PG Targeting to match single String or Integer value #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And1sS
reviewed
Dec 28, 2021
| @@ -269,6 +284,18 @@ private static Integer nodeToInteger(JsonNode node) { | |||
| return node.isInt() ? node.asInt() : null; | |||
| } | |||
|
|
|||
| private static <T> List<T> nodeToListOfStrings(JsonNode node, Function<JsonNode, T> valueExtractor) { | |||
There was a problem hiding this comment.
Why not private static List<String> nodeToListOfStrings(JsonNode node, Function<JsonNode, String> valueExtractor), I mean why do we use generic return type, when method name implies that return type should be List<String>?
added 2 commits
January 13, 2022 13:28
…-and-integer # Conflicts: # src/main/java/org/prebid/server/deals/targeting/RequestContext.java # src/test/java/org/prebid/server/deals/targeting/RequestContextTest.java
And1sS
approved these changes
Jan 13, 2022
rpanchyk
deleted the
deals/extend-targeting-matching-for-string-and-integer
branch
marki1an
pushed a commit
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed targeting matching for:
bidp.,ufpd.,sfpd.Before, this request only matched:
Now, the request like:
will be matched for: