Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make container count to be configurable #1655

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Tests: Make container count to be configurable #1655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9a1fd9
Externalize max number of containers through pom.xml and lower the de…
Dec 28, 2021
4595db5
fix after review
Dec 28, 2021
c2baa0d
fix after review
Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-functional-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
${{ runner.os }}-maven-

- name: Build with Maven
run: mvn -B verify -DskipUnitTests=true --file extra/pom.xml
run: mvn -B verify -DskipUnitTests=true -Dmax.containers.count=5 --file extra/pom.xml
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@
<allure.results.directory>target/allure-results</allure.results.directory>
<mockserver.version>${mockserver-client.version}</mockserver.version>
<pbs.version>${project.version}</pbs.version>
<max.containers.count>2</max.containers.count>
</systemPropertyVariables>
</configuration>
<executions>
Expand Down
2 changes: 1 addition & 1 deletion src/test/groovy/org/prebid/server/functional/testcontainers/PbsServiceFactory.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import org.prebid.server.functional.util.ObjectMapperWrapper
class PbsServiceFactory {

private static final Map<Map<String, String>, PrebidServerContainer> containers = [:]
private static final int MAX_CONTAINERS_COUNT = 5
private static final Integer MAX_CONTAINERS_COUNT = Integer.valueOf(System.getProperty("max.containers.count"))
Net-burst marked this conversation as resolved.
Show resolved Hide resolved

private final ObjectMapperWrapper mapper
private final NetworkServiceContainer networkServiceContainer
Expand Down