Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Unruly Adapter: Refactor #1662

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

marki1an
Copy link
Collaborator

No description provided.

@marki1an marki1an requested a review from And1sS January 5, 2022 09:47
@marki1an marki1an force-pushed the bidder/unruly/consolidated_adapter branch from 3c425df to aaafe28 Compare January 6, 2022 11:26
Copy link
Member

@And1sS And1sS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you please remove redundant ImpExtUnruly model and imp ext parsing? In go they just marshall and unmarshall to get rid of everything except imp.ext.bidder

it can be done, for example, this way:

private Imp modifyImp(Imp imp) {
        final ObjectNode modifiedExt = mapper.mapper().createObjectNode()
                .set("bidder", imp.getExt().get("bidder"));

        return imp.toBuilder().ext(modifiedExt).build();
    }

@marki1an marki1an force-pushed the bidder/unruly/consolidated_adapter branch from aaafe28 to 27a04ce Compare January 11, 2022 15:39
@marki1an marki1an force-pushed the bidder/unruly/consolidated_adapter branch from 27a04ce to 573fa33 Compare January 12, 2022 13:34
@marki1an marki1an closed this Jan 21, 2022
@marki1an marki1an reopened this Jan 21, 2022
@marki1an marki1an force-pushed the bidder/unruly/consolidated_adapter branch 2 times, most recently from 84ec253 to d9ab2f8 Compare January 21, 2022 15:08
@marki1an marki1an force-pushed the bidder/unruly/consolidated_adapter branch from d9ab2f8 to 522044c Compare January 21, 2022 15:09
@marki1an marki1an requested a review from And1sS January 21, 2022 15:14
@SerhiiNahornyi SerhiiNahornyi merged commit a198b44 into master Feb 18, 2022
@SerhiiNahornyi SerhiiNahornyi deleted the bidder/unruly/consolidated_adapter branch February 18, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants