-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Unruly Adapter: Refactor #1662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested review from
And1sS,
rpanchyk,
SerhiiNahornyi and
yevhenii-viktorov
December 31, 2021 13:59
And1sS
requested changes
Dec 31, 2021
src/test/java/org/prebid/server/bidder/unruly/UnrulyBidderTest.java
Outdated
Show resolved
Hide resolved
marki1an
force-pushed
the
bidder/unruly/consolidated_adapter
branch
from
January 6, 2022 11:26
3c425df
to
aaafe28
Compare
And1sS
requested changes
Jan 11, 2022
src/test/java/org/prebid/server/bidder/unruly/UnrulyBidderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/unruly/UnrulyBidder.java
Outdated
Show resolved
Hide resolved
And1sS
reviewed
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you please remove redundant ImpExtUnruly model and imp ext parsing? In go they just marshall and unmarshall to get rid of everything except imp.ext.bidder
it can be done, for example, this way:
private Imp modifyImp(Imp imp) {
final ObjectNode modifiedExt = mapper.mapper().createObjectNode()
.set("bidder", imp.getExt().get("bidder"));
return imp.toBuilder().ext(modifiedExt).build();
}
marki1an
force-pushed
the
bidder/unruly/consolidated_adapter
branch
from
January 11, 2022 15:39
aaafe28
to
27a04ce
Compare
marki1an
force-pushed
the
bidder/unruly/consolidated_adapter
branch
from
January 12, 2022 13:34
27a04ce
to
573fa33
Compare
marki1an
force-pushed
the
bidder/unruly/consolidated_adapter
branch
2 times, most recently
from
January 21, 2022 15:08
84ec253
to
d9ab2f8
Compare
marki1an
force-pushed
the
bidder/unruly/consolidated_adapter
branch
from
January 21, 2022 15:09
d9ab2f8
to
522044c
Compare
And1sS
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.