-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for the test framework #1755
Conversation
269e1bb
to
dc7575e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor remarks
dc7575e
to
280b7f5
Compare
280b7f5
to
ffb1731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor remarks
docs/developers/functional-tests.md
Outdated
|
||
**Properties:** | ||
|
||
`launchContainers` - responsible for starting the MockServer and the MySQLContainer container. Default value is false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a note that default value is false to not launch containers for unit tests.
...st/groovy/org/prebid/server/functional/testcontainers/container/PrebidServerContainer.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.