Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the test framework #1755

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

mtuchkova
Copy link
Contributor

No description provided.

@mtuchkova mtuchkova added the tests Functional or other tests label Feb 22, 2022
@mtuchkova mtuchkova requested a review from Net-burst February 22, 2022 10:52
@mtuchkova mtuchkova force-pushed the add-documentation-for-test-framework branch 2 times, most recently from 269e1bb to dc7575e Compare February 22, 2022 15:27
hupaloo
hupaloo previously approved these changes Mar 1, 2022
Copy link
Contributor

@hupaloo hupaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remarks

docs/developers/functional-tests.md Outdated Show resolved Hide resolved
docs/developers/functional-tests.md Outdated Show resolved Hide resolved
docs/developers/functional-tests.md Outdated Show resolved Hide resolved
@mtuchkova mtuchkova force-pushed the add-documentation-for-test-framework branch from dc7575e to 280b7f5 Compare March 24, 2022 15:45
@mtuchkova mtuchkova requested a review from hupaloo March 24, 2022 15:45
@mtuchkova mtuchkova force-pushed the add-documentation-for-test-framework branch from 280b7f5 to ffb1731 Compare March 24, 2022 16:18
hupaloo
hupaloo previously approved these changes Mar 24, 2022
Net-burst
Net-burst previously approved these changes Mar 25, 2022
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor remarks

docs/developers/functional-tests.md Show resolved Hide resolved

**Properties:**

`launchContainers` - responsible for starting the MockServer and the MySQLContainer container. Default value is false.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a note that default value is false to not launch containers for unit tests.

@mtuchkova mtuchkova dismissed stale reviews from Net-burst and hupaloo via f0acf18 March 30, 2022 10:12
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerhiiNahornyi SerhiiNahornyi merged commit 0908fe1 into master Mar 30, 2022
@SerhiiNahornyi SerhiiNahornyi deleted the add-documentation-for-test-framework branch March 30, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants