Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telaria: add pod support #1763

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Telaria: add pod support #1763

merged 7 commits into from
Mar 22, 2022

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Mar 9, 2022 •
edited
Loading

@marki1an marki1an requested review from And1sS and CTMBNara March 9, 2022 10:26
@lgtm-com
Copy link

lgtm-com bot commented Mar 9, 2022

This pull request introduces 1 alert when merging 36f7f2b into fd82693 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Mar 9, 2022

This pull request introduces 1 alert when merging 7b1b945 into fd82693 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@marki1an marki1an requested a review from And1sS March 9, 2022 16:04
And1sS
And1sS previously approved these changes Mar 11, 2022
View reviewed changes
@marki1an marki1an requested a review from And1sS March 21, 2022 10:31
SerhiiNahornyi
SerhiiNahornyi suggested changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add test where bid impId will b resolved from imp.id

@marki1an marki1an requested a review from SerhiiNahornyi March 22, 2022 11:25
@SerhiiNahornyi SerhiiNahornyi merged commit 0d8eaf9 into master Mar 22, 2022
@SerhiiNahornyi SerhiiNahornyi deleted the telaria/add_pod_support branch March 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

@CTMBNara CTMBNara Awaiting requested review from CTMBNara

@And1sS And1sS Awaiting requested review from And1sS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marki1an @And1sS @SerhiiNahornyi