Core: Add validation by BIDDER.yaml for media types #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
changed the title
And1sS
previously requested changes
Apr 4, 2022
src/main/java/org/prebid/server/bidder/BidderMediaTypeProcessor.java
Outdated
Show resolved
Hide resolved
mtuchkova
reviewed
Apr 4, 2022
src/main/java/org/prebid/server/bidder/BidderMediaTypeProcessor.java
Outdated
Show resolved
Hide resolved
muuki88
reviewed
Apr 15, 2022
|
|
||
| public interface MediaTypeProcessor { | ||
|
|
||
| MediaTypeProcessingResult process(BidRequest bidRequest, String supportedBidderName); |
There was a problem hiding this comment.
It would be awesome to add some documentation what the use cases are for this processor is
| @@ -34,8 +35,8 @@ public static BidderInfo create(boolean enabled, | |||
| String endpoint, | |||
| String aliasOf, | |||
| String maintainerEmail, | |||
| List<String> appMediaTypes, | |||
| List<String> siteMediaTypes, | |||
| List<MediaType> appMediaTypes, | |||
There was a problem hiding this comment.
I really appreciate string being replaced by proper types 👍
…media-type # Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
…media-type # Conflicts: # src/main/java/org/prebid/server/bidder/BidderInfo.java # src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy # src/test/java/org/prebid/server/bidder/BidderCatalogTest.java # src/test/java/org/prebid/server/handler/info/BidderDetailsHandlerTest.java
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
SerhiiNahornyi
changed the title
…media-type # Conflicts: # src/main/java/org/prebid/server/bidder/HttpBidderRequester.java
SerhiiNahornyi
force-pushed
the
add-filter-for-imp-media-type
branch
from
dceefe2 to
688155e
Compare
SerhiiNahornyi
suggested changes
Jun 27, 2022
src/main/java/org/prebid/server/auction/mediatypeprocessor/BidderMediaTypeProcessor.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/mediatypeprocessor/BidderMediaTypeProcessor.java
Outdated
Show resolved
Hide resolved
SerhiiNahornyi
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.