-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubMatic: Add support for "Acat" ext parameter #1813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested review from
And1sS and
CTMBNara
and removed request for
And1sS
April 11, 2022 11:20
We have a Client waiting for this so hoping we can release this relatively soon. Please let me know if I can be of any help. |
yevhenii-viktorov
suggested changes
Apr 19, 2022
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/pubmatic/PubmaticBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/pubmatic/PubmaticBidderTest.java
Outdated
Show resolved
Hide resolved
…arameter # Conflicts: # src/test/java/org/prebid/server/bidder/pubmatic/PubmaticBidderTest.java
yevhenii-viktorov
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SerhiiNahornyi
changed the title
PubMatic add support "Acat" field request ext parameter
PubMatic: Add support for "Acat" ext parameter
Apr 28, 2022
CTMBNara
requested changes
Apr 29, 2022
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Apr 29, 2022
src/main/java/org/prebid/server/bidder/pubmatic/PubmaticBidder.java
Outdated
Show resolved
Hide resolved
CTMBNara
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding ticket : 2201