Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImproveDigital bidder : Google additional consent support #1816

Merged
merged 7 commits into from
May 5, 2022
Merged

ImproveDigital bidder : Google additional consent support #1816

merged 7 commits into from
May 5, 2022

Conversation

marki1an
Copy link
Collaborator

Corresponding ticket : 2202

@marki1an marki1an requested a review from And1sS April 12, 2022 11:26
yevhenii-viktorov
yevhenii-viktorov suggested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@yevhenii-viktorov yevhenii-viktorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comments.

src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidder.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/improvedigital/ImprovedigitalBidderTest.java Show resolved Hide resolved
yevhenii-viktorov
yevhenii-viktorov reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@yevhenii-viktorov yevhenii-viktorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comment, please.

yevhenii-viktorov
yevhenii-viktorov previously approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@yevhenii-viktorov yevhenii-viktorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together.

@CTMBNara CTMBNara self-requested a review April 29, 2022 11:23
@marki1an marki1an requested a review from CTMBNara May 4, 2022 08:42
@SerhiiNahornyi SerhiiNahornyi merged commit 4a84b96 into master May 5, 2022
@SerhiiNahornyi SerhiiNahornyi deleted the improvedigital/additional-consent-support branch May 5, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

@yevhenii-viktorov yevhenii-viktorov yevhenii-viktorov left review comments

@CTMBNara CTMBNara CTMBNara left review comments

@And1sS And1sS Awaiting requested review from And1sS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marki1an @CTMBNara @SerhiiNahornyi @yevhenii-viktorov