Default auction type was defined as 1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schernysh
suggested changes
Apr 3, 2018
| result = bidRequest.toBuilder() | ||
| .device(populatedDevice != null ? populatedDevice : bidRequest.getDevice()) | ||
| .site(populatedSite != null ? populatedSite : bidRequest.getSite()) | ||
| .user(populatedUser != null ? populatedUser : bidRequest.getUser()) | ||
| // set the auction type to 1 if it wasn't on the request, | ||
| // since header bidding is generally a first-price auction. | ||
| .at(at == null || at == 0 ? 1 : at) |
There was a problem hiding this comment.
This construct will bite you as it bit me, refer to https://github.com/rubicon-project/prebid-server-java/blob/b984362a449c7d0b882deccf6d47fe92d7842f70/src/main/java/org/prebid/server/auction/AmpRequestFactory.java#L117 for solution
|
|
||
| if (populatedDevice != null || populatedSite != null || populatedUser != null) { | ||
| if (populatedDevice != null || populatedSite != null || populatedUser != null || at == null || at == 0) { |
There was a problem hiding this comment.
at == null || at == 0 condition appears twice in this method and could be extracted to a variable
| @Test | ||
| public void shouldNotSetAtIfItIsNotEqualsToNull(){ | ||
| // given | ||
| givenBidRequest(BidRequest.builder() |
There was a problem hiding this comment.
This could be a one-liner
schernysh
approved these changes
Apr 3, 2018
v-dridger
added a commit
to v-dridger/prebid-server-java
that referenced
this pull request
Mar 16, 2023
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Sep 22, 2023
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Dec 11, 2023
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Dec 12, 2023
muuki88
added a commit
to highfivve/prebid-server-java
that referenced
this pull request
Jan 22, 2024
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Jan 29, 2024
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Feb 26, 2024
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Feb 26, 2024
muuki88
added a commit
to highfivve/prebid-server-java
that referenced
this pull request
Mar 9, 2024
muuki88
added a commit
to highfivve/prebid-server-java
that referenced
this pull request
Mar 9, 2024
muuki88
added a commit
to highfivve/prebid-server-java
that referenced
this pull request
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.