Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cross-repo-issue.yml for omit tests label #2140

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Update cross-repo-issue.yml for omit tests label #2140

merged 3 commits into from
Feb 6, 2023

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Feb 1, 2023

No description provided.

@marki1an marki1an added enhancement New improvement do not port labels Feb 1, 2023
bretg
bretg requested changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is going to work.

  1. I think the operator should be AND
  2. If for some reason it is OR, then we probably need parenthesis to ensure the order of operations.

This needs to be tested.

@marki1an
Copy link
Collaborator Author

marki1an commented Feb 2, 2023

I'm not sure this is going to work.

  1. I think the operator should be AND
  2. If for some reason it is OR, then we probably need parenthesis to ensure the order of operations.

This needs to be tested.

@bretg Yep, you're right, it won't work, we must use AND conditional, also spent some time to test it and it'll work now.

@marki1an marki1an requested a review from bretg February 2, 2023 11:59
@SerhiiNahornyi SerhiiNahornyi merged commit 82a0c95 into master Feb 6, 2023
@SerhiiNahornyi SerhiiNahornyi deleted the update-cross-repo-issue-for-tests-label branch February 6, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@SerhiiNahornyi SerhiiNahornyi Awaiting requested review from SerhiiNahornyi

Assignees
No one assigned
Labels
do not port enhancement New improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marki1an @bretg @SerhiiNahornyi