Appush: Add adapter #2142
Merged
Appush: Add adapter #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Feb 8, 2023
| import lombok.Value; | ||
|
|
||
| @AllArgsConstructor(staticName = "of") | ||
| @Value |
There was a problem hiding this comment.
@Value(staticConstrucor= "of")
| String type; | ||
|
|
||
| @JsonProperty(value = "placementId") | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) |
There was a problem hiding this comment.
Looks useless, this should be held on bidder-code side, same for line 19
| } | ||
| } | ||
|
|
||
| throw new PreBidException(String.format(FAILED_TO_FIND_IMPRESSION_ERROR_MESSAGE, impId)); |
There was a problem hiding this comment.
WE don't need FAILED_TO_FIND_IMPRESSION_ERROR_MESSAGE constant, pls just inline this
| return imp.toBuilder().ext(modifiedImpExtBidder).build(); | ||
| } | ||
|
|
||
| private AppushImpExtBidder buildImpExtAppushWithType(ExtImpAppush extImpAppush) { |
There was a problem hiding this comment.
Pls rename to resolveImpExt()
Also method can be static
|
|
||
| private AppushImpExtBidder buildImpExtAppushWithType(ExtImpAppush extImpAppush) { | ||
|
|
||
| AppushImpExtBidder.AppushImpExtBidderBuilder builder = AppushImpExtBidder.builder(); |
There was a problem hiding this comment.
We prefer to use final keyword for variables, pls check similar occurrences
SerhiiNahornyi
approved these changes
Feb 9, 2023
osulzhenko
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.