KiviAds: Add adapter #2156
Merged
KiviAds: Add adapter #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SerhiiNahornyi
suggested changes
Feb 20, 2023
|
|
||
| String type; | ||
|
|
||
| @JsonProperty(value = "placementId") |
There was a problem hiding this comment.
Value= is not necessary, pls remove
Also, check similar occurrences
| } | ||
| }, | ||
| "oneOf": [ | ||
| { "required": ["placementId"] }, |
There was a problem hiding this comment.
Pls format this file with Idea formatter
| impExtKiviAds | ||
| .type("network") | ||
| .endpointId(extImpKiviAds.getEndpointId()); | ||
| } else if (StringUtils.isNotEmpty(extImpKiviAds.getPlacementId())) { |
There was a problem hiding this comment.
In Go implementation first check for publisher type than for network
SerhiiNahornyi
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding ticket: prebid/prebid-server#2446, issue: #2160