Clickonometrics: Add adapter #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Feb 15, 2023
|
|
||
| @Test | ||
| public void creationShouldFailOnInvalidEndpointUrl() { | ||
| assertThatIllegalArgumentException().isThrownBy(() -> new GenericBidder("invalid_url", jacksonMapper)); |
There was a problem hiding this comment.
not generic, but CcxBidder
| .map(SeatBid::getBid) | ||
| .filter(Objects::nonNull) | ||
| .flatMap(Collection::stream) | ||
| .map(bid -> BidderBid.of(bid, BidType.banner, bidResponse.getCur())) |
There was a problem hiding this comment.
For supporting video, pls check example
AndBeyondMediaBidder.getBidType
| } | ||
|
|
||
| @Test | ||
| public void makeHttpRequestsShouldCreateExpectedUrl() { |
There was a problem hiding this comment.
Pls create test to check that incoming and outcoming bidRequest are equal
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()) | ||
| .containsExactly(BidderBid.of(givenBid(), banner, "USD")); |
There was a problem hiding this comment.
After the bidType change, pls update it to be video
SerhiiNahornyi
changed the title
SerhiiNahornyi
approved these changes
Feb 16, 2023
osulzhenko
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the yaml, the adapter supports both banner and video but in the code, the adapter only supports for the banner. I've followed the code to create this adapter. Please let me know if the adapter needs to be updated to support both video and banner.