Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeWheelSsp: Add adapter #2251

Merged
merged 1 commit into from
Mar 31, 2023
Merged

FreeWheelSsp: Add adapter #2251

merged 1 commit into from
Mar 31, 2023

Conversation

wesley-freestar
Copy link
Contributor

No description provided.

@SerhiiNahornyi SerhiiNahornyi linked an issue Mar 23, 2023 that may be closed by this pull request
Port freewheelssp adapter #2168
Closed
And1sS
And1sS reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@And1sS And1sS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be a generic bidder alias

@wesley-freestar
Copy link
Contributor Author

Can be a generic bidder alias

@And1sS can you explain what you mean, please?

do you mean that the FreewheelSSPBidder is not needed and in FreewheelSSPConfiguration, the GenericBidder should be used instead?

@And1sS
Copy link
Member

And1sS commented Mar 23, 2023

Can be a generic bidder alias

@And1sS can you explain what you mean, please?

do you mean that the FreewheelSSPBidder is not needed and in FreewheelSSPConfiguration, the GenericBidder should be used instead?

Please, refer to prebid java docs for more information.

@SerhiiNahornyi SerhiiNahornyi changed the title freewheelssp: Add adapter FreeWheelSsp: Add adapter Mar 24, 2023
@Net-burst
Copy link
Collaborator

Net-burst commented Mar 29, 2023 •
edited
Loading

@wesley-freestar here's an example of a similar case: #2243
Sorry for the vague guideline. This can be done for cases where there is no need for any custom functionality like validation, enrichment, etc. Both ways are valid.

@SerhiiNahornyi SerhiiNahornyi merged commit 2868203 into prebid:master Mar 31, 2023
@wesley-freestar wesley-freestar deleted the freewheelssp-add-adapter branch May 3, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@And1sS And1sS And1sS approved these changes

@SerhiiNahornyi SerhiiNahornyi Awaiting requested review from SerhiiNahornyi

Assignees
No one assigned
Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port freewheelssp adapter
4 participants
@wesley-freestar @And1sS @Net-burst @SerhiiNahornyi