Tests for GPP: Transmit UFPD Activity #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
added
work in progress
marki1an
requested changes
Apr 24, 2023
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
...ovy/org/prebid/server/functional/tests/privacy/activity/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
4 times, most recently
from
c5e7bde to
6042466
Compare
marki1an
requested changes
Apr 25, 2023
src/test/groovy/org/prebid/server/functional/model/bidderspecific/Rp.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
force-pushed
the
test-allow-activities-gpp
branch
from
57c47a0 to
ffe28fa
Compare
marki1an
requested changes
Apr 27, 2023
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitUfpdActivitiesSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
from
6696af4 to
630f22a
Compare
Net-burst
reviewed
Apr 30, 2023
| def genericBidderRequest = bidder.getBidderRequest(genericBidRequest.id) | ||
|
|
||
| verifyAll { | ||
| genericBidderRequest.device |
There was a problem hiding this comment.
Please make sure that in such cases there are proper data from the BidRequest when possible and not "something".
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
2 times, most recently
from
d40cd67 to
cd10dc5
Compare
osulzhenko
changed the title
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
from
cd10dc5 to
7fff6d6
Compare
osulzhenko
force-pushed
the
test-allow-activities-gpp
branch
from
de5cd79 to
70add20
Compare
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
2 times, most recently
from
6e7cd3e to
96cc4ed
Compare
osulzhenko
force-pushed
the
transmit-ufpd-test-gpp
branch
from
96cc4ed to
ff613b2
Compare
marki1an
requested changes
May 4, 2023
Comment on lines
54
to
61
| genericBidderRequest.device.didsha1 | ||
| genericBidderRequest.device.didmd5 | ||
| genericBidderRequest.device.dpidsha1 | ||
| genericBidderRequest.user.buyeruid | ||
| genericBidderRequest.user.yob | ||
| genericBidderRequest.user.gender | ||
| genericBidderRequest.user.eids | ||
| genericBidderRequest.user.data |
There was a problem hiding this comment.
And last one.
- Check if the same data as in BidRequest.
- user.ext.data, device.(ifa,macsha1,macmd5,dpidsha1,dpidmd5,didsha1,didmd5) this fields also need populate and check that are the same or not if activity disallow it.
marki1an
approved these changes
May 4, 2023
CTMBNara
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.