Core: Add new OwnAdx bidder
#2868
Conversation
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/ownadx/OwnAdxBidder.java
Outdated
Show resolved
Hide resolved
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()) | ||
| .flatExtracting(HttpRequest::getImpIds) | ||
| .containsExactlyInAnyOrder(firstId, secondId, firstId, secondId); |
There was a problem hiding this comment.
so what is the difference between the bid requests?
There was a problem hiding this comment.
@marki1an please add .hasSize(2)
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBidsFromOwnAdx() throws IOException, JSONException { | ||
| // given | ||
| WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/ownadx-exchange/bid//")) |
There was a problem hiding this comment.
@SerhiiNahornyi isn't that weird URL? I don't understand why the json requires only one of those params while the URL needs all three
I also don't see any example on the GO side when they cover the case of now having at least one of those params
There was a problem hiding this comment.
I thinking about it, I suppose owned.json should contain those params in one required block.
Apart that GO has differend naming between ownadx.json(inside json either, I hope it's typo) and imp_ownadx.go.
There was a problem hiding this comment.
https://github.com/prebid/prebid.github.io/pull/4687/files describes all the fields as mandatory... I suppose it's a mistake on the GO side, but it's worth discussing with @SerhiiNahornyi
There was a problem hiding this comment.
Please point this question to @bretg, json schema definitely needs to be updated
So we need to reach OwnAdx
There was a problem hiding this comment.
@marki1an any updates here?
anyway I suggest following the requirements, where all the URL parts are mandatory
| return endpointUrl | ||
| .replace(ACCOUNT_ID_MACROS_ENDPOINT, ownAdx.map(ExtImpOwnAdx::getSspId).orElse("")) | ||
| .replace(ZONE_ID_MACROS_ENDPOINT, ownAdx.map(ExtImpOwnAdx::getSeatId).orElse("")) | ||
| .replace(SOURCE_ID_MACROS_ENDPOINT, ownAdx.map(ExtImpOwnAdx::getTokenId).orElse("")); |
|
Depends on prebid/prebid-server#3774 |
|
We can also add updates from this issue #3260 |
|
Depends on prebid/prebid-server#3813 |
No description provided.