Yieldmo Adapter: add currency conversion for bid floors #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
May 22, 2024
| .build(); | ||
| } | ||
|
|
||
| private Price convertBidFloor(Price bidFloorPrice, String impId, BidRequest bidRequest) { |
There was a problem hiding this comment.
This logic is not covered with unit tests
There was a problem hiding this comment.
Tests have now been added, sorry about that.
|
Example can be found here |
…nging behavior of Yieldmo Adapter to continue with original bid floor and bid floor currency if currency conversion fails
SerhiiNahornyi
suggested changes
Jun 3, 2024
| .flatExtracting(BidRequest::getImp).doesNotContainNull() | ||
| .extracting(Imp::getBidfloor, Imp::getBidfloorcur) | ||
| .containsOnly(tuple(convertedBidFloor, "USD")); | ||
|
|
There was a problem hiding this comment.
Redundant empty line
| .flatExtracting(BidRequest::getImp).doesNotContainNull() | ||
| .extracting(Imp::getBidfloor, Imp::getBidfloorcur) | ||
| .containsOnly(tuple(BigDecimal.ONE, "EUR")); | ||
|
|
There was a problem hiding this comment.
Redundant empty line
| final BidRequest bidRequest = givenBidRequest(impBuilder -> | ||
| impBuilder.bidfloor(BigDecimal.ONE).bidfloorcur("EUR")); | ||
|
|
||
| final var convertedBidFloor = new BigDecimal("1.5"); |
There was a problem hiding this comment.
we are not using vars, only strict types
|
|
||
| return Price.of(USD_CURRENCY, convertedPrice); | ||
| } catch (PreBidException e) { | ||
| //If currency conversion fails, we still want to recieve the bid request. |
There was a problem hiding this comment.
Nitpick. Typo and space
// If currency conversion fails, we still want to receive the bid request.
There was a problem hiding this comment.
I have fixed the above issues. Thanks for reviewing.
SerhiiNahornyi
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds currency conversion for bid floors to the yieldmo adapter. I wasn't able to find any documentation around this feature, so this is largely based off of the implementations found in other adapters.