Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triplelift Native Bidder Update #3335

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Triplelift Native Bidder Update #3335

merged 5 commits into from
Aug 1, 2024

Conversation

AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Jul 29, 2024
@AntoxaAntoxic AntoxaAntoxic linked an issue Jul 29, 2024 that may be closed by this pull request
Port PR from PBS-Go: Triplelift Native: Mapping tag_code #3325
Closed
@CTMBNara
Copy link
Collaborator

Also, please, update triplelift_native.json

@AntoxaAntoxic AntoxaAntoxic requested a review from CTMBNara July 31, 2024 10:59
CTMBNara
CTMBNara requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please, update the whole bidder. There is a new changes on GO side.

src/main/java/org/prebid/server/bidder/tripleliftnative/TripleliftNativeExtImp.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/tripleliftnative/TripleliftNativeExtImpData.java Outdated Show resolved Hide resolved
@AntoxaAntoxic AntoxaAntoxic linked an issue Aug 1, 2024 that may be closed by this pull request
Port PR from PBS-Go: Fix: Triplelift Native add site.publisher nil check #3336
Closed
@SerhiiNahornyi SerhiiNahornyi merged commit 9a919bc into master Aug 1, 2024
5 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the triplelift-native-bidder-update branch August 1, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CTMBNara CTMBNara CTMBNara approved these changes

@SerhiiNahornyi SerhiiNahornyi Awaiting requested review from SerhiiNahornyi

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels
do not port
Projects
None yet
Milestone
No milestone
3 participants
@AntoxaAntoxic @CTMBNara @SerhiiNahornyi