Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: JaCoCo config cleanup #3349

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Aug 1, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Move JaCoCo to parent pom.xml so that code coverage data is generated for modules too.

🧠 Rationale behind the change

JaCoCo coverage reports were not generated, and only base PBS coverage data was collected. This PR fixes that.

🧪 Test plan

No impact on production code, so no need for testing.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

SerhiiNahornyi
SerhiiNahornyi previously approved these changes Aug 2, 2024
@SerhiiNahornyi SerhiiNahornyi merged commit 03fc557 into master Aug 6, 2024
4 of 5 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the jacoco-config-update branch August 6, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants