QT: Add adapter #3355
Merged
QT: Add adapter #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
force-pushed
the
bidder/qt-implementation
branch
2 times, most recently
from
2d9c785 to
962ba5e
Compare
AntoxaAntoxic
requested changes
Aug 7, 2024
SerhiiNahornyi
force-pushed
the
bidder/qt-implementation
branch
from
1a103b8 to
8b926aa
Compare
Comment on lines
288
to
290
| BidRequest.builder() | ||
| .imp(singletonList(Imp.builder().id("321").build())) | ||
| .build(), |
There was a problem hiding this comment.
the BidRequest is redundant, so I suggest using null payload in the givenHttpCall and remove this parameter at all
AntoxaAntoxic
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.