Remove all imp.ext.prebid.imp #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
force-pushed
the
imp-exp-prebid-imp-fix
branch
from
0b28785 to
06e4b21
Compare
marki1an
reviewed
Aug 19, 2024
| @@ -156,6 +157,34 @@ class ImpRequestSpec extends BaseSpec { | |||
| bidderName << [WILDCARD, UNKNOWN] | |||
| } | |||
|
|
|||
| def "PBS shouldn't update imp fields without warning when imp.ext.prebid.imp contain not applicable bidder"() { | |||
There was a problem hiding this comment.
PBS shouldn't update imp fields and without warning when imp.ext.prebid.imp contain not applicable bidder
marki1an
reviewed
Aug 19, 2024
| def bidRequest = BidRequest.defaultBidRequest.tap { | ||
| imp.first.tap { | ||
| pmp = impPmp | ||
| ext.prebid.imp = [(notApplicableBidder): new Imp(pmp: Pmp.defaultPmp)] |
There was a problem hiding this comment.
Can be directly ext.prebid.imp = [(RUBICON): new Imp(pmp: Pmp.defaultPmp)]
marki1an
reviewed
Aug 19, 2024
| then: "Bid response should not contain warning" | ||
| assert !response?.ext?.warnings | ||
|
|
||
| and: "BidderRequest shouldn't update imp information based on imp.ext.prebid.imp value" |
There was a problem hiding this comment.
Sounds strange
BidderRequest should contain pmp from imp.ext.prebid.imp.pmp
osulzhenko
changed the title
marki1an
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check