Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a functional test to ensure that bidder implementation is always merged #3397

Conversation

osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Aug 22, 2024

…n is always merged

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added the tests Functional or other tests label Aug 22, 2024
@osulzhenko osulzhenko requested a review from marki1an August 22, 2024 08:32
@osulzhenko osulzhenko self-assigned this Aug 22, 2024
@osulzhenko osulzhenko changed the title Add a functional test to ensure that the correct bidder implementatio… Add a functional test to ensure that bidder implementation is always merged Aug 22, 2024
@osulzhenko osulzhenko requested a review from marki1an August 23, 2024 06:29
Copy link
Collaborator

@marki1an marki1an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osulzhenko osulzhenko merged commit 161409e into imp-ext-prebid-imp-merge-fix Aug 23, 2024
@osulzhenko osulzhenko deleted the functional-tests/imp-ext-prebid-imp-merge-fix branch August 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants