Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTB House: resolve oRTB AUCTION_PRICE macro #3421

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

piotrj-rtbh
Copy link
Contributor

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

The adapter is now able to resolve ${AUCTION_PRICE} macro in win notify URLs.

🧠 Rationale behind the change

Win notify URLs contain the macro. It has to be resolved with the default bidder's currency.
PBS-Go counterpart PR: prebid/prebid-server#3901

🧪 Test plan

Tests passed. Expected behavior tested locally.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Other information

Please reach us at inventory_support@rtbhouse.com with piotr.jaworski@rtbhouse.com and cc leandro.otani@rtbhouse.com.

@piotrj-rtbh piotrj-rtbh marked this pull request as ready for review September 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants