Response correction: Fix VAST matching #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And1sS
force-pushed
the
response-correction/vast-fix
branch
from
0b349e7 to
a178a07
Compare
marki1an
requested changes
Oct 11, 2024
| @@ -1,5 +1,6 @@ | |||
| package org.prebid.server.functional.tests.module.responsecorrenction | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove please empty line
|
|
||
| where: | ||
| admValue << [ | ||
| "${PBSUtils.randomString}<${' ' * PBSUtils.getRandomNumber(0, 20)}VAST ${PBSUtils.randomString}", |
There was a problem hiding this comment.
Why 20 spaces, is it a restriction?
marki1an
previously approved these changes
Oct 11, 2024
Compile-Ninja
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Response correction module does not match VAST markup correctly.