Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX: fix ix adapter handling of paapi config #3563

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

oronno
Copy link
Contributor

@oronno oronno commented Nov 21, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

This is the fix of paapi auction config handling for IX Adapter as described in #3562

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

This change aligns with how Index Exchange formats the auction configuration for the PAAPI response.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hosts
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko linked an issue Nov 25, 2024 that may be closed by this pull request
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Nov 26, 2024
@CTMBNara CTMBNara merged commit 5643eae into prebid:master Nov 28, 2024
7 checks passed
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IX: Incorrect Handling of FledgeAuctionConfig in Bidder Response
4 participants