Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use video.plcmt to Resolve Media Type #3572

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

AntoxaAntoxic
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Nov 22, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • tech debt (test coverage, refactorings, etc.)
  • configuration

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • NO fully dynamic hosts
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Nov 22, 2024
@osulzhenko osulzhenko requested a review from CTMBNara November 28, 2024 08:02
CTMBNara
CTMBNara previously approved these changes Nov 28, 2024
* Update test cases for plcmt logic to bidadjustment mediatype determination
@CTMBNara CTMBNara merged commit 9cb9a83 into master Dec 4, 2024
7 checks passed
@CTMBNara CTMBNara deleted the resolve-media-type-for-bid-adjustments branch December 4, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants