Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests for module execution host config check #3589

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Functional tests for module execution host config check #3589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44550ae
Functional tests for module execution host config check
osulzhenko Dec 1, 2024
dc703cc
Update due to provided comments
osulzhenko Dec 2, 2024
9124491
Merge branch 'refs/heads/module-execution-fix' into functional-tests/…
osulzhenko Dec 3, 2024
8af9a14
update functional tests
osulzhenko Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/test/groovy/org/prebid/server/functional/model/config/AccountHooksConfiguration.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ class AccountHooksConfiguration {
@JsonProperty("execution_plan")
ExecutionPlan executionPlanSnakeCase
PbsModulesConfig modules
AdminConfig admin
}
13 changes: 13 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/config/AdminConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package org.prebid.server.functional.model.config

import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString
import org.prebid.server.functional.model.ModuleName

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.KebabCaseStrategy)
class AdminConfig {

Map<ModuleName, Boolean> moduleExecution
}
3 changes: 1 addition & 2 deletions src/test/groovy/org/prebid/server/functional/model/response/auction/TraceOutcome.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ package org.prebid.server.functional.model.response.auction
import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString
import org.prebid.server.functional.model.config.Stage

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.LowerCaseStrategy)
class TraceOutcome {

Stage entity
String entity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not stage?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because BIDDER_REQUEST, RAW_BIDDER_RESPONSE, and PROCESSED_BIDDER_RESPONSE from beginning had bidder as entity and stage as a separate parameter, we didn’t have any tests for it previously, so it was implemented as a Stage. However, this is not accurate. You can check it here:
#1345

Long executionTimeMillis
List<TraceGroup> groups
}
Loading