Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp: update consented providers settings support #3590

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

And1sS
Copy link
Member

@And1sS And1sS commented Dec 3, 2024

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Apparently Google documentation had an error. To avoid breaking changes we now support both ConsentedProvidersSettings and consented_providers_settings fields.

🧪 Test plan

Unit tests + functional tests.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@CTMBNara CTMBNara merged commit f6276c9 into master Dec 3, 2024
5 checks passed
@CTMBNara CTMBNara deleted the amp/update-consented-providers-settings-support branch December 3, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants