Tests: Add adUnitCode to exception list #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
changed the base branch from
master
to
add-adunitcode-to-exception-list
osulzhenko
added
tests
marki1an
requested changes
Dec 10, 2024
Comment on lines
30
to
31
| @JsonProperty("adunitcode") | ||
| String adUnitCode |
There was a problem hiding this comment.
Should be in imp[].ext.prebid.adunitcode
| and: "Response shouldn't contain warning" | ||
| assert !response.ext?.warnings | ||
|
|
||
| "Bidder request should bidderParams only for bidder" |
There was a problem hiding this comment.
and keyword before a text
…ional-tests/adunitcode-to-exception-list
marki1an
requested changes
Dec 16, 2024
| } | ||
| } | ||
|
|
||
| def "PBS shouldn't emit warning and proceed auction when all ext.prebid.bidderParams fields known for PBS"() { |
There was a problem hiding this comment.
Please correct test name, since for now sounds like we shouldn't proceed auction
marki1an
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check