-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3574 add driftpixel userSync redirect url #3613
base: master
Are you sure you want to change the base?
Conversation
Seems the currency service failed
|
Done |
I'm confused why the tests fail π |
@muuki88 Hi, I found an issue that looks like: |
Thanks a lot @marki1an I'll take a look. Should I research for a way to make the test output more accessible? There were quite a lot of exceptions that all seemed unrelated |
Okay. This crashed the entire application start π |
I'm not 100% sure that there are no external services involved π
|
userSync: | ||
cookie-family-name: driftpixel | ||
redirect: | ||
url: "https://sync.driftpixel.live/psync?t=s&e=0&gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&cb={{redirect_url}}" | ||
support-cors: false | ||
userMacro: "%USER_ID%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usersync:
cookie-family-name: driftpixel
redirect:
url: "https://sync.driftpixel.live/psync?t=s&e=0&gdpr={{gdpr}}&consent={{gdpr_consent}}&us_privacy={{us_privacy}}&cb={{redirect_url}}"
support-cors: false
uid-macro: '%USER_ID%'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muuki88 please copy-paste the provided config and it will work (I hope)
π§ Type of changes
β¨ What's the context?
Ported from Go version: prebid/prebid-server#3973
π§ Rationale behind the change
Keep bidder implementations in sync
π§ͺ Test plan
π€
π Quality check