-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greenbids fix geolookup: host and fetch GCS + mock dbReader UT #3626
Open
EvgeniiMunin
wants to merge
7
commits into
prebid:master
Choose a base branch
from
EvgeniiMunin:greenbids-fix-geolookup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgeniiMunin
changed the title
Greenbids fix geolookup: mock dbReader TU + host GCS
Greenbids fix geolookup: host and fetch GCS + mock dbReader TU
Dec 13, 2024
EvgeniiMunin
changed the title
Greenbids fix geolookup: host and fetch GCS + mock dbReader TU
Greenbids fix geolookup: host and fetch GCS + mock dbReader UT
Dec 13, 2024
EvgeniiMunin
force-pushed
the
greenbids-fix-geolookup
branch
from
December 13, 2024 18:56
e5faad5
to
ee640d3
Compare
AntoxaAntoxic
requested changes
Dec 16, 2024
...a/org/prebid/server/hooks/modules/greenbids/real/time/data/config/DatabaseReaderFactory.java
Outdated
Show resolved
Hide resolved
...a/org/prebid/server/hooks/modules/greenbids/real/time/data/config/DatabaseReaderFactory.java
Outdated
Show resolved
Hide resolved
...server/hooks/modules/greenbids/real/time/data/config/GreenbidsRealTimeDataConfiguration.java
Outdated
Show resolved
Hide resolved
...prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInferenceDataService.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
approved these changes
Dec 16, 2024
Groovy IT is failing
I will push an empty commit to see if it is a flaky one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
🧠 Rationale behind the change
GeoLite2-Country.mmdb
in Greenbids GCS bucket instead of open source URL: gs://greenbids-europe-west1-prebid-server-staging/GeoLite2-Country.mmdbgetCountry(ip)
only in case ifDevice::getGeo
is null (geoLookupEnabled is false in GeoLocationServiceWrapper)🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check