Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impression tracking to VAST (Server-Side) #437

Merged
merged 7 commits into from
Sep 5, 2019
Merged

Add impression tracking to VAST (Server-Side) #437

merged 7 commits into from
Sep 5, 2019

Conversation

RossGoncharuk
Copy link
Contributor

  • Added impression tracking to VAST xml when account has events enabled and for bidders that allow modifying VAST xml;
  • Added new bidder configuration property - modifyingVastXmlAllowed with a default value false;
  • Adjusted ExchangeService and CacheService flows to process changing VAST xml;
  • Corrected existing unit tests and added new ones to reflect the changes.

@RossGoncharuk RossGoncharuk requested a review from rpanchyk August 23, 2019 13:36
rpanchyk
rpanchyk suggested changes Aug 27, 2019
View reviewed changes
src/main/java/org/prebid/server/auction/ExchangeService.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/cache/CacheService.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/proto/response/BidderInfo.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/cache/CacheService.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/model/BidderConfigurationProperties.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/auction/ExchangeServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/auction/ExchangeServiceTest.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/cache/CacheService.java Outdated Show resolved Hide resolved
@bretg
Copy link
Collaborator

bretg commented Aug 27, 2019

I'd like the default modifyingVastXmlAllowed to be true.

@rpanchyk rpanchyk changed the title Add impression tracking to VAST Add impression tracking to VAST (Server-Side) Sep 4, 2019
@rpanchyk rpanchyk merged commit 4b3b6e2 into master Sep 5, 2019
@rpanchyk rpanchyk deleted the add-impression-tracking branch September 5, 2019 08:43
@bretg bretg mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg requested changes

@rpanchyk rpanchyk rpanchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RossGoncharuk @bretg @rpanchyk