Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor events service #459

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Refactor events service #459

merged 2 commits into from
Sep 16, 2019

Conversation

rpanchyk
Copy link
Contributor

This PR removes event.url-template configuration property and rely all parsing/composing event URLs to EventUtil and EventsService classes.

@rpanchyk rpanchyk requested a review from schernysh September 16, 2019 10:43
@schernysh schernysh merged commit 5e72671 into master Sep 16, 2019
@schernysh schernysh deleted the refactor-events-service branch September 16, 2019 12:28
@bretg bretg mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schernysh schernysh schernysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpanchyk @schernysh