Update First Party Data workflow and introduce Bidder Config #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/resources/org/prebid/server/it/cache/update/test-auction-response.json # src/test/resources/org/prebid/server/it/openrtb2/adform/test-auction-adform-response.json # src/test/resources/org/prebid/server/it/openrtb2/adkernel/test-auction-adkernel-response.json # src/test/resources/org/prebid/server/it/openrtb2/adkerneladn/test-auction-adkerneladn-response.json # src/test/resources/org/prebid/server/it/openrtb2/adpone/test-auction-adpone-response.json # src/test/resources/org/prebid/server/it/openrtb2/adtelligent/test-auction-adtelligent-response.json # src/test/resources/org/prebid/server/it/openrtb2/advangelists/test-auction-advangelists-response.json # src/test/resources/org/prebid/server/it/openrtb2/beachfront/test-auction-beachfront-response.json # src/test/resources/org/prebid/server/it/openrtb2/brightroll/test-auction-brightroll-response.json # src/test/resources/org/prebid/server/it/openrtb2/conversant/alias/test-auction-conversant-response.json # src/test/resources/org/prebid/server/it/openrtb2/conversant/test-auction-conversant-response.json # src/test/resources/org/prebid/server/it/openrtb2/engagebdr/test-auction-engagebdr-response.json # src/test/resources/org/prebid/server/it/openrtb2/facebook/test-auction-facebook-response.json # src/test/resources/org/prebid/server/it/openrtb2/gamoshi/test-auction-gamoshi-response.json # src/test/resources/org/prebid/server/it/openrtb2/grid/test-auction-grid-response.json # src/test/resources/org/prebid/server/it/openrtb2/gumgum/test-auction-gumgum-response.json # src/test/resources/org/prebid/server/it/openrtb2/improvedigital/test-auction-improvedigital-response.json # src/test/resources/org/prebid/server/it/openrtb2/ix/test-auction-ix-response.json # src/test/resources/org/prebid/server/it/openrtb2/lifestreet/test-auction-lifestreet-response.json # src/test/resources/org/prebid/server/it/openrtb2/lockerdome/test-auction-lockerdome-response.json # src/test/resources/org/prebid/server/it/openrtb2/mgid/test-auction-mgid-response.json # src/test/resources/org/prebid/server/it/openrtb2/openx/test-auction-openx-response.json # src/test/resources/org/prebid/server/it/openrtb2/pubmatic/test-auction-pubmatic-response.json # src/test/resources/org/prebid/server/it/openrtb2/pulsepoint/test-auction-pulsepoint-response.json # src/test/resources/org/prebid/server/it/openrtb2/rhythmone/test-auction-rhythmone-response.json # src/test/resources/org/prebid/server/it/openrtb2/rtbhouse/test-auction-rtbhouse-response.json # src/test/resources/org/prebid/server/it/openrtb2/somoaudience/test-auction-somoaudience-response.json # src/test/resources/org/prebid/server/it/openrtb2/sonobi/test-auction-sonobi-response.json # src/test/resources/org/prebid/server/it/openrtb2/sovrn/test-auction-sovrn-response.json # src/test/resources/org/prebid/server/it/openrtb2/synacormedia/test-auction-synacormedia-response.json # src/test/resources/org/prebid/server/it/openrtb2/tappx/test-auction-tappx-response.json # src/test/resources/org/prebid/server/it/openrtb2/triplelift/test-auction-triplelift-response.json # src/test/resources/org/prebid/server/it/openrtb2/ttx/test-auction-ttx-response.json # src/test/resources/org/prebid/server/it/openrtb2/unruly/test-auction-unruly-response.json # src/test/resources/org/prebid/server/it/openrtb2/verizonmedia/test-auction-verizonmedia-response.json # src/test/resources/org/prebid/server/it/openrtb2/verizonmedia/test-verizonmedia-bid-request-1.json # src/test/resources/org/prebid/server/it/openrtb2/visx/test-auction-visx-response.json # src/test/resources/org/prebid/server/it/openrtb2/vrtcal/test-auction-vrtcal-response.json # src/test/resources/org/prebid/server/it/openrtb2/yieldmo/test-auction-yieldmo-response.json
|
This pull request introduces 1 alert when merging a4395f8 into dde2146 - view on LGTM.com new alerts:
|
# Conflicts: # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
|
This pull request introduces 1 alert when merging c8d62ef into 6acad88 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 92887aa into 6acad88 - view on LGTM.com new alerts:
|
# Conflicts: # src/test/resources/org/prebid/server/it/openrtb2/facebook/test-facebook-bid-request-1.json
|
This pull request introduces 1 alert when merging 7e59386 into f9b0c17 - view on LGTM.com new alerts:
|
rpanchyk
requested review from
schernysh and
DGarbar
and removed request for
rpanchyk
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtRequestPrebid.java # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-appnexus-bid-request-1.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/test/resources/org/prebid/server/it/openrtb2/datablocks/test-auction-datablocks-response.json # src/test/resources/org/prebid/server/it/openrtb2/emxdigital/test-auction-emxdigital-response.json # src/test/resources/org/prebid/server/it/openrtb2/kubient/test-auction-kubient-response.json # src/test/resources/org/prebid/server/it/openrtb2/kubient/test-kubient-bid-request-1.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-appnexus-bid-request-1.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-appnexus-bid-request-2.json # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-rubicon-bid-request-2.json # src/test/resources/org/prebid/server/it/openrtb2/synacormedia/test-synacormedia-bid-request.json # src/test/resources/org/prebid/server/it/openrtb2/tripleliftnative/test-auction-triplelift-native-response.json
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java
DGarbar
previously approved these changes
Feb 21, 2020
|
This pull request introduces 1 alert when merging 90ebb6b into 3a982b4 - view on LGTM.com new alerts:
|
schernysh
reviewed
Feb 25, 2020
|
This pull request introduces 1 alert when merging 6399f6a into c2f6bb1 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging d2de2e5 into 2b53488 - view on LGTM.com new alerts:
|
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtRequestPrebid.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/resources/org/prebid/server/it/openrtb2/brightroll/test-brightroll-bid-request-1.json # src/test/resources/org/prebid/server/it/openrtb2/datablocks/test-auction-datablocks-response.json # src/test/resources/org/prebid/server/it/openrtb2/kubient/test-auction-kubient-response.json # src/test/resources/org/prebid/server/it/openrtb2/smartrtb/test-smartrtb-bid-request.json # src/test/resources/org/prebid/server/it/openrtb2/synacormedia/test-synacormedia-bid-request.json # src/test/resources/org/prebid/server/it/openrtb2/tripleliftnative/test-auction-triplelift-native-response.json
|
This pull request introduces 1 alert when merging 6fd26e1 into 0ac5a89 - view on LGTM.com new alerts:
|
added 2 commits
May 22, 2020 15:37
# Conflicts: # src/main/java/org/prebid/server/auction/AmpRequestFactory.java
|
This pull request introduces 1 alert when merging 5db231d into fa0429c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 815e083 into fa0429c - view on LGTM.com new alerts:
|
added 2 commits
June 3, 2020 16:20
rpanchyk
approved these changes
Jun 3, 2020
|
This pull request introduces 1 alert when merging 9647883 into fa0429c - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated First Party Data processing workflow and introduced Bidder Config support to match PBS behavior to what is required in prebid issue 879
AMP and Auction.
Fix bug when we enforced fpd for request without bidderconfig list.
(Now this behavior can be reproduced when this parameter set to
{})Implement PR