Gamoshi Bidder updating cookie #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndriyPavlyuk
commented
Jan 15, 2020
•
AndriyPavlyuk
commented
- Updated Gamoshi endpoint URL query parameters;
- Updated Gamoshi Usersync URL.
AndriyPavlyuk
requested review from
RossGoncharuk
and removed request for
rpanchyk
|
Just to duplicate what I've commented in #584 - simply break what you've done into a separate logical points and describe them. This should be an introduction or an overview to what you've changed. Thanks! |
RossGoncharuk
suggested changes
Jan 16, 2020
There was a problem hiding this comment.
While you've done the first part of PR right (which is changing the query params of http request uri), you've forgot the second part, which ironically is a name of this PR - update a usersync cofiguration in bidder's settings.
Please update the usersync.url in gamoshi.yaml with the value they have in config/config.go at GO version (check their GO PR attentively).
RossGoncharuk
approved these changes
Jan 16, 2020
rpanchyk
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.